Draft: Refactor testsuite #70
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
we should also add |
commit 459d202 (prefix special defines with FORTIFY_) changed define. Adjust the testsuite accordingly.
Use `gcc` as default and pass the CC compiler with the github workflow instead.
This makes it possible to do multiple runs without needing to clean in between.
This allows us to disable warnings on Alpine Linux by doing: make -C tests FORTIFY_CFLAGS="-U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=3" It also makes it possible to run the tests with -D_FORTIFY_SOURCE=2 without modifying the Makefile.
Set the system depended includes in github workflows, where we also define the syste (ubuntu, x86_64 etc). This makes it easier to run test suite on Alpine
- include a `config.mk` if it exists. This is useful to set local cflags
while debugging. For example:
echo "CFLAGS+=-U_FORTIFY_SOURCE" > config.mk
- Remove 'gcc' and 'clang' targets. Let user set that via CC.
- Add a `check` target, so user can run the test suite with
`make check`.
- set -nostdinc always to avoid pull in system headers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor testsuite so the platform dependant (C compiler) and header loactions are more together.
Don't make assumptions on CC or platform to make it easier to run testsuite natively on Alpine, on any architecture.
fixes #69