Merge pull request #221 from nrgbodya/bugfix/flickering

Bugfix/flickering
jverdi · Jul 12, 2021 · 69c0e80 · 69c0e80
2 parents 2026f5d + 04ba76d
commit 69c0e80
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 4 deletions.
diff --git a/JVFloatLabeledTextField/JVFloatLabeledTextField/JVFloatLabeledTextField.m b/JVFloatLabeledTextField/JVFloatLabeledTextField/JVFloatLabeledTextField.m
@@ -283,7 +283,7 @@ - (CGRect)textRectForBounds:(CGRect)bounds
     if ([self.text length] || self.keepBaseline) {
         rect = [self insetRectForBounds:rect];
     }
-    return CGRectIntegral(rect);
+    return rect;
 }
 
 - (CGRect)editingRectForBounds:(CGRect)bounds
@@ -292,7 +292,7 @@ - (CGRect)editingRectForBounds:(CGRect)bounds
     if ([self.text length] || self.keepBaseline) {
         rect = [self insetRectForBounds:rect];
     }
-    return CGRectIntegral(rect);
+    return rect;
 }
 
 - (CGRect)insetRectForBounds:(CGRect)rect
@@ -314,7 +314,7 @@ - (CGRect)clearButtonRectForBounds:(CGRect)bounds
             rect = CGRectMake(rect.origin.x, rect.origin.y + topInset / 2.0f, rect.size.width, rect.size.height);
         }
     }
-    return CGRectIntegral(rect);
+    return rect;
 }
 
 - (CGRect)leftViewRectForBounds:(CGRect)bounds

diff --git a/JVFloatLabeledTextField/JVFloatLabeledTextField/JVFloatLabeledTextView.m b/JVFloatLabeledTextField/JVFloatLabeledTextField/JVFloatLabeledTextView.m
@@ -340,7 +340,7 @@ - (CGRect)textRect
         rect.origin.y += self.textContainerInset.top;
     }
 
-    return CGRectIntegral(rect);
+    return rect;
 }
 
 - (void)setFloatingLabelFont:(UIFont *)floatingLabelFont

diff --git a/JVFloatLabeledTextFieldTests/JVFloatLabeledTextFieldTests.m b/JVFloatLabeledTextFieldTests/JVFloatLabeledTextFieldTests.m
@@ -89,4 +89,15 @@ - (void)testKeepBaseline
     XCTAssert(CGRectEqualToRect(clearRectInitial, clearRectFinal));
 }
 
+-(void)testIntrinsicContentHeight
+{
+    self.testField.text = @"foo";
+    CGFloat firstHeight = self.testField.intrinsicContentSize.height;
+
+    self.testField.text = @"bar";
+    CGFloat secondHeight = self.testField.intrinsicContentSize.height;
+
+    XCTAssertEqual(firstHeight, secondHeight);
+}
+
 @end