-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(multitenancy): add a fallback for get commands in redis #7043
base: main
Are you sure you want to change the base?
Conversation
…k_for_redis_prefix_get
75b41f7
to
e31f032
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also why are none of the stream redis commands not having this fallback logic?
Retrying streams is a little tricky because |
Type of Change
Description
Motivation and Context
To keep the tenant data isolated from each other, We are using a prefix for Redis keys i.e A key which would be saved as card123 without multitenancy would be saved as public:card123 with Multitenancy.
If the user makes a payment on the older pod where MultiTenancy is disabled and client_secret is saved without a prefix, Now if the confirm calls goes to the pod where Multitenancy is enabled the Payment would fail with Unauthorized. This is just one of the instances where the payments would fail.
How did you test it?
** THIS CANNOT BE TESTED ON HIGHER ENVIRONMENTS **
Checklist
cargo +nightly fmt --all
cargo clippy