feat: migrate local strings to S3 #866
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aritro2002
added
Ready for Review
aritro2002
requested review from
Sanskar2001,
seekshiva,
PritishBudhiraja,
ArushKapoorJuspay and
sakksham7
as code owners
manideepk90
reviewed
Jan 21, 2025
| stateEmptyText: "State cannot be empty", | ||
| ibanEmptyText: "IBAN cannot be empty", | ||
| selectPaymentMethodText: "Please select a payment method and try again", | ||
| achBankDebitTermsWeb: "Your ACH Debit Authorization will be set up now, but we'll confirm the amount and let you know before future payments are taken.", |
There was a problem hiding this comment.
For consistency, replace ach, becs, bacs terms with single text which is more readable and user friendly
There was a problem hiding this comment.
don't create seperate terms for web
manideepk90
reviewed
Jan 21, 2025
| | SV => Js.import(SwedishLocale.localeStrings) | ||
| | RU => Js.import(RussianLocale.localeStrings) | ||
| | ZH_HANT => Js.import(TraditionalChineseLocale.localeStrings) | ||
| let baseUrl = switch ( |
There was a problem hiding this comment.
Create a utility function that can be used for states and countries in future
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Migrate local strings to S3
How did you test it?
I tested in local demo store.
Checklist
npm run re:build