chore: logs added for paze and samsung pay #812
+92
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sakksham7
added
the
Ready for Review
sakksham7
requested review from
Sanskar2001,
seekshiva,
PritishBudhiraja and
ArushKapoorJuspay
as code owners
|
Review changes with Changed Files
|
PritishBudhiraja
approved these changes
Nov 28, 2024
Sanskar2001
reviewed
Nov 28, 2024
| @@ -279,9 +278,12 @@ let make = (publishableKey, options: option<JSON.t>, analyticsInfo: option<JSON. | |||
| let samsungPayScript = Window.createElement("script") | |||
| samsungPayScript->Window.elementSrc(samsungPayScriptUrl) | |||
| samsungPayScript->Window.elementOnerror(err => { | |||
| Console.log2("ERROR LOADING SAMSUNG PAY SCRIPT", err) | |||
| logInfo(Console.log2("ERROR DURING LOADING SAMSUNG PAY SCRIPT", err)) | |||
There was a problem hiding this comment.
Is it sending a network request? I believe it should be like
logger.setLogInfo(~value="ERROR DURING LOADING GOOGLE PAY SCRIPT", ~eventName=SAMSUNG_PAY_SCRIPT)
There was a problem hiding this comment.
Its just a normal console log, if the env is not prod then it will console for better debugging purposes, should this be changed to a log only?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Added logs for samsung pay and paze
How did you test it?
Tested via checking network calls
Checklist
npm run re:build