Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the broken link to CONTRIBUTING.md #737

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

hxrshxz
Copy link
Contributor

@hxrshxz hxrshxz commented Jan 12, 2025

References

#736

The Link redirects to CONTRIBUTING.md now

@hxrshxz
Copy link
Contributor Author

hxrshxz commented Jan 12, 2025

@meeseeksdev tag bug

Copy link

lumberbot-app bot commented Jan 12, 2025

Awww, sorry hxrshxz you do not seem to be allowed to do that, please ask a repository maintainer.

@krassowski krassowski added the documentation Improvements or additions to documentation label Jan 13, 2025
Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @hxrshxz!

For context, this fixes a link on https://lumino.readthedocs.io/en/latest/api/index.html

@krassowski
Copy link
Member

The check_links job failure is unrelated (caused by temporary binder.org issues):

FAILED binder/README.md::/home/runner/work/lumino/lumino/binder/README.md

@krassowski krassowski changed the title Fixed the Broken link Fixed the broken link to CONTRIBUTING.md Jan 13, 2025
@krassowski krassowski merged commit 76e4a90 into jupyterlab:main Jan 13, 2025
18 of 22 checks passed
@hxrshxz hxrshxz deleted the patch-1 branch January 13, 2025 11:07
@hxrshxz
Copy link
Contributor Author

hxrshxz commented Jan 13, 2025

The check_links job failure is unrelated (caused by temporary binder.org issues):

FAILED binder/README.md::/home/runner/work/lumino/lumino/binder/README.md

Thank you for pointing that out, i won't lose any more of my time on that thinking something's wrong at my end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants