Let user defines its own xstartup and geometry via ~/.vnc/xstartup

[cmd-ntrf]

User can override the default provided xstartup by providing their own in the standard location ~/.vnc/xstartup. We also remove the prescribed geometry to let the user define its own using vnc config or the session manager.

[github-actions]

👈 Launch a binder notebook on this branch for commit b01c897

👈 Launch a binder notebook on this branch for commit e89c17e

👈 Launch a binder notebook on this branch for commit 66fb7a2

👈 Launch a binder notebook on this branch for commit cf02bd8

👈 Launch a binder notebook on this branch for commit fb47c59

[consideRatio]

We remove -geometry, but what happens if nothing is specified now? Are users installing this to expect a change, perhaps a change depending on default config for turbovnc / tigervnc?

I think this makes sense overall, but I think the geometry aspect requires some docs, inline comments, and clarity with regards to if its a breaking change and if so guidance for users handling this breaking change.

[yuvipanda]

I couldn't push to this branch for some reason, so I've amended this and opened #45.

[cmd-ntrf]

Regarding the removal of -geometry, based on my experience, when -geometry is left undefined, the desktop is started with a resolution of 1024x768.
This is also what is specified in the manual:
https://github.com/TigerVNC/tigervnc/blob/8d2739fa71eaf7a28d63ac62583e8087c66a5247/unix/xserver/hw/vnc/Xvnc.man#L35
and in Xvnc C code:
https://github.com/TigerVNC/tigervnc/blob/8d2739fa71eaf7a28d63ac62583e8087c66a5247/unix/xserver/hw/vnc/xvnc.c#L77

Any reason why we would want to substitute this low resolution value by another arbitrary default value? I would argue that a lower resolution has higher chance of being the appropriate fit for most screen. Even more, if we consider the desktop is actually displayed in a browser tab.

In any case, the users could change bypass the resolution set on the command-line by specifying the geometry in ~/.vnc/config. They can also dynamically change the resolution settings using Xfce Display application.

[yuvipanda]

Yay, welcome back @cmd-ntrf!

I think mostly people now expect the default to be 1680x1050 because that's what we have been shipping with, and this change would change the default practically to 1024x768. That's the primary reason I'd like that change to not be here as part of this PR. That's a significant drop in resolution!

If you can split that out into a separate PR, we can discuss that, as allowing custom xstartup is simple and useful by itself.

[cmd-ntrf]

Alright, let's split this!

[yuvipanda]

Wheeee, thanks @cmd-ntrf!

[cmd-ntrf]

Sorry for the long pause... life got busy.

[yuvipanda]

@cmd-ntrf no worries at all! Grateful for your ongoing contributions whenever you can <3