refactor: small readability and consistency details #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TigerVNC listens to localhost by default, and TurboVNC doesn't. Let's make them do the same. When websockify starts either TigerVNC or TurboVNC, it will listen only to localhost anyhow - so this doesn't change anything really but could reduce the complexity a bit when debugging these things, as I've done at length now.
consideRatio
commented
Mar 29, 2024
Comment on lines
-40
to
+41
| vnc_args = [vncserver, '-rfbport', '{port}'] | ||
| socket_args = [] | ||
| websockify_args = [] | ||
| vnc_args = [vncserver, '-localhost', '-rfbport', '{port}'] |
There was a problem hiding this comment.
About passing -localhost to turbovnc
This won't change anything, its just about making both VNC servers startup as localhost and not just TigerVNC for consistency.
TigerVNC listens to localhost by default, and TurboVNC doesn't. Let's make them do the same.
When websockify starts either TigerVNC or TurboVNC, it will listen only to localhost anyhow - so this doesn't change anything really but could reduce the complexity a bit when debugging these things, as I've done at length now.
No change, just relocates code.
|
I'll go for a self-merge and prepare a changelog for a release |
consideRatio
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.