Close clipboard if clicked anywhere outside clipboard

jupyterhub · Jul 14, 2024 · 05c6af9 · 05c6af9
1 parent b4ef5ac
commit 05c6af9
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/js/clipboard.js b/js/clipboard.js
@@ -11,7 +11,7 @@ import "./clipboard.css";
  * @param {Element} trigger
  * @param {Element} clipboard
  */
-export function setupClipboard(trigger, clipboard, canvas) {
+export function setupClipboard(trigger, clipboard, parent) {
   const arrowElement = clipboard.querySelector(".arrow");
   function updatePosition() {
     computePosition(trigger, clipboard, {
@@ -53,14 +53,15 @@ export function setupClipboard(trigger, clipboard, canvas) {
     trigger.classList.toggle("active");
     updatePosition();
     e.preventDefault();
+    e.stopPropagation();
   });
 
   // If the clipboard is clicked this should not be passed to the desktop
   clipboard.addEventListener("click", (e) => {
     e.stopPropagation();
   });
   // Close the popup if we click outside it
-  canvas.addEventListener("click", () => {
+  parent.addEventListener("click", () => {
     if (trigger.classList.contains("active")) {
       clipboard.classList.toggle("hidden");
       trigger.classList.toggle("active");

diff --git a/js/index.js b/js/index.js
@@ -85,7 +85,7 @@ function connect() {
   setupClipboard(
     document.getElementById("clipboard-button"),
     document.getElementById("clipboard-container"),
-    document.getElementsByTagName("canvas")[0],
+    document.body,
   );
 }