Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attribute non-test thread output to most recent test thread #4200

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

marcphilipp
Copy link
Member

When using frameworks or running external processes, test output is
often written on other threads than the test. When tests are executed
sequentially that output can be attributed unambiguously to the current
test. If tests are run in parallel, picking the right test to attribute
output to becomes much harder, though.

@marcphilipp marcphilipp self-assigned this Dec 13, 2024
@marcphilipp marcphilipp added this to the 5.12 M1 milestone Dec 13, 2024
@mpkorstanje
Copy link
Contributor

mpkorstanje commented Dec 14, 2024

If tests are run in parallel, picking the right test to attribute output to becomes much harder, though.

When executing in parallel, you could attach any output that can't be attributed to a test to the currently running engine. That would at least preserve some context.

It would require some communication between the platform and engine. Not sure where that would go.

When using frameworks or running external processes, test output is
often written on other threads than the test. When tests are executed
sequentially that output can be attributed unambiguously to the current
test. If tests are run in parallel, picking the right test to attribute
output to becomes much harder, though.
@marcphilipp marcphilipp force-pushed the marc/non-test-thread-output-capturing branch from 96c6788 to 393f60c Compare December 16, 2024 07:56
@marcphilipp marcphilipp marked this pull request as ready for review December 16, 2024 09:11
@marcphilipp
Copy link
Member Author

When executing in parallel, you could attach any output that can't be attributed to a test to the currently running engine. That would at least preserve some context.

It would require some communication between the platform and engine. Not sure where that would go.

Thanks for the idea! I don't think there's a perfect solution for this use case without explicitly attaching threads to tests or sth. like that. The current solution will capture output on the engine descriptor only if no test/container is still running.

@marcphilipp marcphilipp merged commit 3997952 into main Dec 16, 2024
16 checks passed
@marcphilipp marcphilipp deleted the marc/non-test-thread-output-capturing branch December 16, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants