Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid multiple class-level annotation lookups #4053

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

marcphilipp
Copy link
Member

Overview

Instead of looking up annotations on the declaring and all enclosing
classes for each test method, each ResourceLockAware test descriptor
now delegates to the ExclusiveResourceCollector of its ancestors which
cache the class-level annotations and ResourceLocksProvider instances.

Resolves #2677.


I hereby agree to the terms of the JUnit Contributor License Agreement.


Definition of Done

Instead of looking up annotations on the declaring and all enclosing
classes for each test method, each `ResourceLockAware` test descriptor
now delegates to the `ExclusiveResourceCollector` of its ancestors which
cache the class-level annotations and `ResourceLocksProvider` instances.

Resolves #2677.
@marcphilipp marcphilipp self-assigned this Oct 7, 2024
@marcphilipp marcphilipp marked this pull request as ready for review October 7, 2024 14:17
@marcphilipp marcphilipp merged commit dceac6e into main Oct 8, 2024
15 checks passed
@marcphilipp marcphilipp deleted the marc/resource-locks-provider-polishing branch October 8, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ExclusiveResource programmatically
1 participant