Drop duplicate isSnapshot variable in Gradle build script
#3413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbrannen
changed the title
isSnapshot variable in Gradle build script
rybak
force-pushed
the
gradle-publishing-isSnapshot-dupe
branch
from
ec67976 to
1e31b96
Compare
|
Force-pushed to tweak the commit message and rebase on fresh |
Publishing conventions plugin calculates `isSnapshot`:
isSnapshot = project.version.toString().contains("SNAPSHOT")
twice:
1. at the top of build script junitbuild.publishing-conventions.gradle.kts
2. in configuration of `Sign` tasks.
Drop the second `val isSnapshot` to make `Sign` task configuration
re-use the variable from the top of the script.
rybak
force-pushed
the
gradle-publishing-isSnapshot-dupe
branch
from
1e31b96 to
fff2c41
Compare
|
Rebased to get the latest fixes for the Java 22 builds, which failed in previous versions of this PR. |
sbrannen
pushed a commit
to sbrannen/junit5
that referenced
this pull request
Oct 30, 2023
…am#3413) Publishing conventions plugin calculates `isSnapshot`: isSnapshot = project.version.toString().contains("SNAPSHOT") twice: 1. at the top of build script junitbuild.publishing-conventions.gradle.kts 2. in configuration of `Sign` tasks. Drop the second `val isSnapshot` to make `Sign` task configuration re-use the variable from the top of the script.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor Gradle code cleanup.
I hereby agree to the terms of the JUnit Contributor License Agreement.