Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

justifyContent prop for Grid instead of justify #25

Merged
merged 1 commit into from
Nov 11, 2021
Merged

justifyContent prop for Grid instead of justify #25

merged 1 commit into from
Nov 11, 2021

Conversation

sreerajmp
Copy link

#24

@sreerajmp
Copy link
Author

@jungrafael

NikolaDeveloper
NikolaDeveloper approved these changes Oct 4, 2021
View reviewed changes
Copy link

@NikolaDeveloper NikolaDeveloper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change makes it compatible with MUI v5

@jungrafael jungrafael merged commit 382e1f9 into jungsoft:master Nov 11, 2021
@jungrafael
Copy link
Member

Thanks for the PR @sreerajmp!

@minro
Copy link

minro commented Nov 23, 2021

When is this planned for release?

@flzozaya
Copy link

Hello @jungrafael
Looks like this change was merged into master branch. But it didn't actually make it to the latest v1.1.92 release? - It is still passing justify instead of justifyContent.

v1.1.92 tag 👉 https://github.com/jungsoft/materialui-daterange-picker/blob/1.1.92/package/src/components/Menu.tsx#L103
master branch 👉 https://github.com/jungsoft/materialui-daterange-picker/blob/master/package/src/components/Menu.tsx#L103

Would it be possible to release?

@flzozaya flzozaya mentioned this pull request Sep 14, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NikolaDeveloper NikolaDeveloper NikolaDeveloper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sreerajmp @jungrafael @minro @flzozaya @NikolaDeveloper