Development Branch from MidgetSpy upstream #342
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Sick-Beard depends on Cheetah to even start, having a requirements.txt (a standard way to declare python project dependencies) makes it easier for users and developers to get it up and running, while also allowing for better dependency tracking, since we can describe the specific versions of required python packages. Then all users/devs need to do is: $ pip install -r requirements.txt
Sick Beard uses redirects after various operations, e.g. adding a show and saving configuration changes. When behind an Apache reverse proxy configured using .htaccess rules only (i.e. where modification to the global Apache configuration is not preferable or possible), CherryPy by default builds redirect URLs based off the internal host instead of the external one, breaking sessions for users accessing Sick Beard by external URLs. This could be regarded as a shortcoming of the CherryPy implementation that Sick Beard is using rather than a Sick Beard problem directly. In any case, the changes in this commit allow Sick Beard to respond to both requests made directly and those made through a reverse proxy, with redirects working as expected in both cases. Thanks to Joel Rivera from the CherryPy Users Google Group for his support in preparing these changes: https://groups.google.com/d/msg/cherrypy-users/P87eOftSb_E/BDU6_1sDjtoJ
…onal 300 results (4 hits total). Mainly for when we search without tvrage id set. Handle when newznab servers take their API offline more gracefully.
Add xml declare when writing .xml files (apparently mede8er requires it..) http://www.mede8erforum.com/index.php/topic,15386.0.html / www.sickbeard.com/forums/viewtopic.php?f=4&t=9634
newznab - tweaks
metadata updates
…ocessing for naming test, otherwise suppress. > This reduces three log messages for each instance, which can add up quickly: provider (+ generic) + metadata + notifier. So four instances for one ep manual search with one provider enabled... so 12 log messages that were not needed.
logging prettyname
-- http://jqueryui.com/changelog/1.11.2/ * Added slider widget for future use.
Upgrade jquery ui 1.11.1 -> 1.11.2
Fix parsing filename from EZRSS feed
…ted Plex Media Server library updates.
Instead of requiring that NewzNab providers use a fixed DTD URI for the newznab XML namespace, search for the nodes with an 'offset' attribute and then use the one with a namespaced tag ending in 'response'.
Instead of using XPath queries which are not supported prior to Python 2.7, grab an iterator to collect nodes of interest.
rewrite freebsd init script
…tances Also adds some simple tests so we can avoid future regressions.
Searched through the code for any usage of urllib and urllib2 and added the unverified ssl context anywhere a url was opened. This allows connecting with HTTPS without checking the SSL certificate, which was the former python default.
Since default behaviour for SSL certificate verification was changed since 2.7.9, I added some version checks so the fix is only used in python versions from then on. This should keep sickbeard compatible with older python versions.
Fix for post-processing when download dir has broken symlinks
config.clean_url may add trailing /'s in unsuitable circumstances.
modified URL openers so they do not check SSL certificates (fixes #2551)
Edited text to say "Sick Beard" instead of "SickBeard" to be in-line with naming conventions.
Plex notifications were failing due to use of getURLFileLike returning a file like object that had not been gzip decoded in line with addheader request.
gzip is a valid and expected response from sab, however it is not handled. Correctly read in response, but continue to provide file like object
The Push API uses one URI and devices another. Use the correct one at the correct time
pull request midgetspy#886 started reading notifications as priorities but wasn't saving them as ints on notification updates. This caused the UI to always display the lowest priority in the select box, regardless of the actual values saved in the config, as there was a type mismatch, in addition subsequent saves would override the setting to be the lowest priority.
The `type="text/javascript"` attribute is unnecessary with the HTML5 doctype. This commit removes them from all SickBeard-originated templates.
Updated naming convention
Use getURL correctly when gzip encoding is a valid response
Correctly read gzip encoded response from sab
Save notification priorities as ints
Add workaround for improperly cleaned scgi over unix domain socket URI
…_attributes Remove unnecessary type attribute from script and style tags.
Use the correct URI for when contructing password manager
Add postprocess to api
EZTV recently changed it's url. Updating this file to reflect that change.
Forgot to commit the actual feed URL as well
index.php not longer needed
New URL for eztv
Add support for Slack as a notifier
…tprocess-frequency Issues 1209,1835,2584: Make scan and process (postprocess) frequency configurable.
…lopment # Conflicts: # data/interfaces/default/config_general.tmpl # data/interfaces/default/config_notifications.tmpl # data/interfaces/default/config_providers.tmpl # data/interfaces/default/config_search.tmpl # requirements.txt # sickbeard/__init__.py # sickbeard/classes.py # sickbeard/config.py # sickbeard/helpers.py # sickbeard/metadata/generic.py # sickbeard/metadata/helpers.py # sickbeard/metadata/tivo.py # sickbeard/naming.py # sickbeard/notifiers/__init__.py # sickbeard/notifiers/nmj.py # sickbeard/notifiers/nmjv2.py # sickbeard/notifiers/plex.py # sickbeard/notifiers/pytivo.py # sickbeard/notifiers/slack.py # sickbeard/notifiers/xbmc.py # sickbeard/nzbSplitter.py # sickbeard/processTV.py # sickbeard/providers/ezrss.py # sickbeard/providers/generic.py # sickbeard/providers/newznab.py # sickbeard/sab.py # sickbeard/show_name_helpers.py # sickbeard/tvrage.py # sickbeard/webserve.py # sickbeard/webserveInit.py
# Conflicts: # sickbeard/__init__.py
Carlos4240
approved these changes
Feb 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you are one of the interested in having lastest development branch of abandoned upstream from midgetspy, please review this PR, download the
latest-developmentbranch and give me feedback.You can test using docker, make sure you checked out the correct branch and run
docker-compose upIssues related: #181
Probably other issues in upstream are covered. Need help to list.