Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for MOI.ScalarNonlinearFunction #256

Merged
merged 4 commits into from
Nov 15, 2023
Merged

Conversation

odow
Copy link
Member

@odow odow commented Nov 14, 2023

Closes #252

This is the minimal viable needed to get an example to run. I'd probably like to clean up the MOI wrapper a bit. It's missing a lot of functionality that I think works only because of the caching optimizer in the tests.

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (5a1d541) 73.52% compared to head (6ed6c8b) 74.07%.

Files Patch % Lines
src/MOI_wrapper/constraints.jl 62.50% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #256      +/-   ##
==========================================
+ Coverage   73.52%   74.07%   +0.55%     
==========================================
  Files          12       12              
  Lines        1809     1832      +23     
==========================================
+ Hits         1330     1357      +27     
+ Misses        479      475       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@odow odow merged commit a8bb86d into master Nov 15, 2023
5 checks passed
@odow odow deleted the od/scalar-nonlinear branch November 15, 2023 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Support MOI.{Scalar,Vector}NonlinearFunction
1 participant