Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NLPBlockDualStart and tidy MOI tests #255

Merged
merged 6 commits into from
Nov 6, 2023
Merged

Fix NLPBlockDualStart and tidy MOI tests #255

merged 6 commits into from
Nov 6, 2023

Conversation

odow
Copy link
Member

@odow odow commented Nov 3, 2023

Closes #233
Closes #250

@odow
Copy link
Member Author

odow commented Nov 3, 2023

Hmm. These passed locally. I need another look

test/MOI_wrapper.jl Outdated Show resolved Hide resolved
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (149c8b6) 73.17% compared to head (40e05d6) 72.84%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #255      +/-   ##
==========================================
- Coverage   73.17%   72.84%   -0.33%     
==========================================
  Files          12       12              
  Lines        1819     1819              
==========================================
- Hits         1331     1325       -6     
- Misses        488      494       +6     
Files Coverage Δ
src/MOI_wrapper/nlp.jl 78.26% <0.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@odow odow merged commit 33db39c into master Nov 6, 2023
3 of 5 checks passed
@odow odow deleted the od/fix-dual branch November 6, 2023 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

MOI.set(model::Optimizer, ::MOI.NLPBlockDualStart, values) does not work Fix excluded tests in MOI
1 participant