Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error for unsupported objective sense #3601

Merged
merged 2 commits into from
Dec 7, 2023
Merged

Fix error for unsupported objective sense #3601

merged 2 commits into from
Dec 7, 2023

Conversation

odow
Copy link
Member

@odow odow commented Dec 7, 2023

Apparently no one has ever noticed that this error is wrong.

Part of #3513

test/test_macros.jl Outdated Show resolved Hide resolved
test/test_macros.jl Outdated Show resolved Hide resolved
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cecc5ba) 98.39% compared to head (741cece) 98.29%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3601      +/-   ##
==========================================
- Coverage   98.39%   98.29%   -0.11%     
==========================================
  Files          38       38              
  Lines        5687     5686       -1     
==========================================
- Hits         5596     5589       -7     
- Misses         91       97       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@odow odow merged commit 59cc031 into master Dec 7, 2023
11 of 12 checks passed
@odow odow deleted the od/sense-error branch December 7, 2023 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant