Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lp_matrix_data #3573

Merged
merged 8 commits into from
Nov 21, 2023
Merged

Add lp_matrix_data #3573

merged 8 commits into from
Nov 21, 2023

Conversation

odow
Copy link
Member

@odow odow commented Nov 15, 2023

Closes #3572

TODO:

  • documentation
  • bike shed the name
  • check lp_sensitivity tests

Copy link

codecov bot commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3015564) 98.38% compared to head (d269bf2) 98.38%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3573   +/-   ##
=======================================
  Coverage   98.38%   98.38%           
=======================================
  Files          37       38    +1     
  Lines        5629     5648   +19     
=======================================
+ Hits         5538     5557   +19     
  Misses         91       91           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jd-foster
Copy link
Collaborator

StandardFormData ?

@odow
Copy link
Member Author

odow commented Nov 15, 2023

Other options:

  • lp_standard_form(model)
  • lp_matrix_data(model)
  • standard_matrix_data(model)
  • standard_matrix_form(model)
  • standard_form_matrix(model)
  • standard_form_matrix_data(model)

I think I like lp_matrix_data. LPMatrixData is a bit ugly, but okay for the name of a struct.

@odow odow changed the title Add StandardFormMatrix Add lp_matrix_data Nov 16, 2023
src/lp_matrix_data.jl Outdated Show resolved Hide resolved
@jd-foster
Copy link
Collaborator

I think the name works well.

@odow odow requested review from blegat and mlubin November 16, 2023 22:06
@odow
Copy link
Member Author

odow commented Nov 16, 2023

@blegat, I think I can anticipate your comment: why not Utilities.MatrixOfConstraints.

I think we potentially could in future, but this is a simple first pass. I'm more interested in your thoughts on the user-facing data structure. There's an argument for providing a matrix and a vector of sets, or A <sense> b, but I think we should target what 99% of people want, which is the matrix and vectors from an LP.

src/lp_matrix_data.jl Outdated Show resolved Hide resolved
@odow odow merged commit 3608379 into master Nov 21, 2023
12 checks passed
@odow odow deleted the od/standard-form-matrix branch November 21, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Add standard_form_matrix
3 participants