Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Percival to list of solvers #3567

Merged
merged 6 commits into from
Nov 28, 2023
Merged

Add Percival to list of solvers #3567

merged 6 commits into from
Nov 28, 2023

Conversation

blegat
Copy link
Member

@blegat blegat commented Nov 7, 2023

Basic

  • Check that the solver is a registered Julia package
  • Check that the solver supports the long-term support release of Julia
  • Check that the solver has a MathOptInterface wrapper
  • Check that the tests call MOI.Test.runtests. Some test excludes are
    permissible, but the reason for skipping a particular test should be
    documented.
  • Check that the README and/or documentation provides an example of how to
    use the solver with JuMP

Documentation

  • Add a new row to the table in docs/src/installation.md

Optional

  • Add package metadata to docs/packages.toml

docs/packages.toml Outdated Show resolved Hide resolved
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (96b4147) 98.37% compared to head (7d70b03) 98.37%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3567   +/-   ##
=======================================
  Coverage   98.37%   98.37%           
=======================================
  Files          38       38           
  Lines        5673     5673           
=======================================
  Hits         5581     5581           
  Misses         92       92           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@odow
Copy link
Member

odow commented Nov 7, 2023

Requires JuliaSmoothOptimizers/Percival.jl#153

docs/packages.toml Outdated Show resolved Hide resolved
docs/packages.toml Outdated Show resolved Hide resolved
@odow odow merged commit 814f490 into master Nov 28, 2023
12 checks passed
@odow odow deleted the bl/percival branch November 28, 2023 02:46
@odow odow mentioned this pull request Nov 28, 2023
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants