-
-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] add EAGO to packages.toml #3561
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3561 +/- ##
==========================================
- Coverage 98.37% 98.20% -0.18%
==========================================
Files 37 37
Lines 5610 5622 +12
==========================================
+ Hits 5519 5521 +2
- Misses 91 101 +10 ☔ View full report in Codecov by Sentry. |
@DimitriAlston here are the vale failures. I've added some (not listed here) to the docs/src/packages/EAGO.md|20 col 317| [Google.Latin] Use 'for example' instead of 'e.g.,'. Should be accommodate docs/src/packages/EAGO.md|123 col 146| [Google.Latin] Use 'for example' instead of 'e.g.,'. Should be Wengert docs/src/packages/EAGO.md|130 col 102| [Vale.Spelling] Did you really mean 'Github'? Should be GitHub docs/src/packages/EAGO.md|143 col 91| [Vale.Spelling] Did you really mean 'lexiographic'? Should be lexicographic docs/src/packages/EAGO.md|155 col 17| [Vale.Spelling] Did you really mean 'bibtex'? Should be BibTeX docs/src/packages/EAGO.md|172 col 213| [Vale.Spelling] Did you really mean 'contactors'? Contractors? docs/src/packages/EAGO.md|178 col 134| [Google.EnDash] Use an em dash ('—') instead of '–'. Optimization docs/src/packages/EAGO.md|180 col 119| [Vale.Spelling] Did you really mean 'Softw'? Software docs/src/packages/EAGO.md|180 col 137| [Google.EnDash] Use an em dash ('—') instead of '–'. |
I'm thinking it might be better if I do something similar to InfiniteOpt. EAGO's README from v0.8.1 has a lot of unnecessary stuff for this so a simplified version for getting started would be better. Also, I realized a lot of the typos I fixed are on my version and haven't been pushed to GitHub yet. |
No problem. Unfortunately, it's a bit of a hassle to test things. The best way is to push a commit to EAGO, then comment here with the hash, and I will rebuild the docs with it. |
I added |
The images probably won't work because I renamed and moved them at some point. |
Alright, I have added a new README to EAGO for this at https://github.com/PSORLab/EAGO.jl/blob/master/docs/src/jump/README.md. |
Yeah. I've updated the commit hash. So if you change, we'll need to update it here. let's see how this one looks |
Oh, I think we forgot to remove |
My bad. See you in another hour. |
Thanks for your patience @DimitriAlston |
Thanks for your help! |
cc @DimitriAlston
It'll take a while for the docs to run, but once they're finished this preview link will work:
https://jump.dev/JuMP.jl/previews/PR3561/packages/EAGO
We need to fix some typos, and add some more words to the allow-list (https://github.com/jump-dev/JuMP.jl/blob/master/docs/styles/Vocab/JuMP-Vocab/accept.txt).
The bigger problem is going to be the formatting and links. Documenter's Markdown is not the same as GitHub, so things will render differently. I'll take a look once the preview has built. But another alternative is to provide a simplified file just for the JuMP documentation.
This is what InfiniteOpt has done:
JuMP.jl/docs/packages.toml
Line 141 in c831cc6
https://github.com/infiniteopt/InfiniteOpt.jl/blob/master/docs/jump/README.md