Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache indices and coefficients vectors between constraints #201

Closed
wants to merge 1 commit into from

Conversation

odow
Copy link
Member

@odow odow commented Dec 7, 2021

No description provided.

@codecov
Copy link

codecov bot commented Dec 7, 2021

Codecov Report

Merging #201 (4e0ea09) into master (5982ae9) will increase coverage by 0.16%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #201      +/-   ##
==========================================
+ Coverage   82.85%   83.01%   +0.16%     
==========================================
  Files           9        9              
  Lines        1761     1766       +5     
==========================================
+ Hits         1459     1466       +7     
+ Misses        302      300       -2     
Impacted Files Coverage Δ
src/MOI_wrapper/MOI_callbacks.jl 95.78% <100.00%> (ø)
src/MOI_wrapper/MOI_wrapper.jl 92.29% <100.00%> (+0.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5982ae9...4e0ea09. Read the comment docs.

@joaquimg
Copy link
Member

joaquimg commented Dec 8, 2021

What is the underlying issue?
Things are being Garbage Collected? if so, shouldn't the solution be: Base.GC.@preserve ?

@joaquimg
Copy link
Member

joaquimg commented Dec 8, 2021

Or the issue is allocating vectors?

@odow
Copy link
Member Author

odow commented Dec 8, 2021

Yes I wondered if it was the source of jump-dev/JuMP.jl#2817. The answer is somewhat, but there must be another culprit. I need to do a better benchmark before merging.

@odow odow closed this Nov 30, 2022
@odow odow deleted the od/performance branch November 30, 2022 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants