FF7: Fix field chunk size calculation for the chunk number 9 #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out we can't actually use known_field_buffer_size after all. :( This causes crashes.
julianxhokaxhiu
changed the title
julianxhokaxhiu
changed the title
julianxhokaxhiu
approved these changes
Dec 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
So since i don't typically run gameplay mods, i missed a crash i caused by trying to use known_field_buffer_size to calculate the actual size of chunk 11. Even trying to do this causes stuff to be written outside the buffer, which is bad. Since ffnx doesn't have it's own decompressor, i can't get the real size. so I have no choice but to trust the section header.
Motivation
Fixing what I broke.
ACKs