Fix #24
Closed
Fix #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliangruber
requested changes
Mar 7, 2022
| @@ -8,8 +8,8 @@ inputs: | |||
| github-token: | |||
| description: 'GitHub Token' | |||
| required: true | |||
| number: | |||
| description: 'Pull Request number' | |||
There was a problem hiding this comment.
please don't remove existing features
| @@ -0,0 +1,16 @@ | |||
| ## Proposed Changes | |||
There was a problem hiding this comment.
please remove this, it has nothing to do with your change
| } | ||
|
|
||
| main().catch(err => core.setFailed(err.message)) | ||
| main().catch(err => core.setFailed(err.message)); |
There was a problem hiding this comment.
please don't change the code style
| if (!labels.includes(approveLabel)) { | ||
| console.log("PR does not include approve-label, exiting"); | ||
| return; | ||
| } |
There was a problem hiding this comment.
I think you're changing this action to something else, it currently is used for approving arbitrary PRs by number, and it looks like you're proposing to change it to one that will auto-approve PRs if they contain a certain label.
Last time I checked there are already actions for this on the marketplace.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
automatically merge.