Skip to content

Commit

Permalink
Merge pull request #121 from huwshimi/update-3.3-schema
Browse files Browse the repository at this point in the history
WD-8065 - Update facades for Juju 3.3
  • Loading branch information
huwshimi authored Jan 11, 2024
2 parents eaa0cb8 + 4ced017 commit 3c0e170
Show file tree
Hide file tree
Showing 23 changed files with 7,396 additions and 124 deletions.
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,4 @@ api/!(test)**/*.js
dist/
.nyc_output/
docs
.nfs.*
14 changes: 8 additions & 6 deletions README.md

Large diffs are not rendered by default.

6 changes: 3 additions & 3 deletions api/client.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ import {
} from "./types.js";
import { createAsyncHandler } from "./utils.js";

export const CLIENT_VERSION = "3.2.1";
export const CLIENT_VERSION = "3.3.2";

export interface ConnectOptions {
bakery?: Bakery | null;
Expand Down Expand Up @@ -271,7 +271,7 @@ class Client {
"user-data": "",
};
const url = this._transport._ws.url;
const origin = new URL(url).origin;
const origin = url;

if (credentials.username && credentials.password) {
args.credentials = credentials.password;
Expand Down Expand Up @@ -540,7 +540,7 @@ class Connection {
const clientRequestedFacades = facades.reduce(
(facadeVersions: { [k: string]: FacadeClassList }, current) => {
if ("versions" in current) {
// generic facade, where we won't the best version
// generic facade, where we want the best version
if (!facadeVersions[current.name]) facadeVersions[current.name] = [];
facadeVersions[current.name].push(...current.versions);
} else {
Expand Down
Loading

0 comments on commit 3c0e170

Please sign in to comment.