ci: fix actions on ubuntu 24.04 runners #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hpidcock
force-pushed
the
fix-release
branch
2 times, most recently
from
5b9a796 to
8bed49b
Compare
hpidcock
force-pushed
the
fix-release
branch
from
8bed49b to
9e21ea9
Compare
hpidcock
commented
Dec 17, 2024
| @@ -80,7 +81,7 @@ jobs: | |||
| if getent group snap_microk8s; then | |||
| microk8s_group=snap_microk8s | |||
| fi | |||
| sg "${microk8s_group}" <<'EOF' | |||
| $(echo sudo su $USER -G ${microk8s_group} -g $(groups | sed "s/\s/ -G /g")) <<'EOF' | |||
wallyworld
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sgdoesn't seem to work with the latest noble runners (it prompts for a password), so I've replaced it with an equivalentsudo suincantation.Other changes here are adding the testing into the build job too, as the build job is just used for PR landing.