Error handling improvements #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce Result<> in some places rather than panics. In particular, some cases which end up with a zero width now return an error rather than panicking. The top-level from_read etc. still unwrap the error.
Add another test case, which has a 2 cell wide character which tries to fit into a width of 1; this previously had an infinite loop but will now return an error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main change is that the underlying functions use
Resultfor error handling rather than panicking for everything. The top level wrappers still panic.Some
unwrap()that would panic on API usage errors have been changed toexpect()with a message which might help.One difference in output: some possible inputs which previously came out wider than requested will now return
Err(Error::TooNarrow).Address #93.