Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace panicing APIs with APIs that return errors #167

Merged
merged 1 commit into from
Sep 20, 2024
Merged

replace panicing APIs with APIs that return errors #167

merged 1 commit into from
Sep 20, 2024

Conversation

sftse
Copy link
Contributor

@sftse sftse commented Sep 12, 2024

Closes #166

@jugglerchris
Copy link
Owner

Thanks!
I have been intending to remove the non-Result APIs before a future 1.0 release, but wary of breaking compatibility. But now that you've prompted it and there's an API breaking change pending anyway, it may as well be now, thanks!

@jugglerchris jugglerchris merged commit 5b91835 into jugglerchris:main Sep 20, 2024
5 checks passed
@sftse sftse deleted the rm-panic-api branch September 20, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace panicing APIs with such returning errors
2 participants
@sftse @jugglerchris