-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix docker network caps #2273
fix docker network caps #2273
Conversation
Signed-off-by: Kristoffer Dalby <[email protected]>
It can be because of github changing the |
I thought so too, but I've now tested with 20, 22 and 24 with the same result... It looks like the docker containers doesnt start, which is odd since it doesnt crash locally. I'll try to get logs from the tailscale containers, but its a bit hard since they dont run. |
Ah i see. This might be it though. You're launching docker with GO and it cant find it in path.
you can try checking docker in the workflow file doing |
Thats just the last test where I tried to call Take a look at the last one and it should be the same error as we see on the other prs. |
Ok, based on that there is no logs for the tailscale client in the log artefact uploaded after the test fails, I suspect that the container might not be starting at all 🤔 |
I think it could be still related. Go launches the commands in a shell that might be stripping everything configured in the path, so the containers won't launch because of that. |
The way we use docker speaks Docker API to the socket. I think I've found the issue, I joined the job to a dev tailnet to be able to ssh in:
So something has changed in the runners not allowing us to do tun devices... |
Compared to an old job from the archive:
|
Ok, so far this is my guess/take:
Any insight, help and so on appreciated, I am quite frustrated so will take a break. |
Ah this is relevant: docker pulled a rug from under our feet. |
This is really interesting, I think it needs to run in privileged mode for it to work. By default its not i think. |
Ok, last commit did the trick, thanks @Erisa for pointing me in the right direction. I'll wrap up the PR later, I want to add some of the new debug/ssh/tailscale steps to the generator so I have them at hand later. |
@juanfont you can review/approve so I can get it in when that is done. |
Signed-off-by: Kristoffer Dalby <[email protected]>
cd0fbae
to
c3a7c40
Compare
c3a7c40
to
d767a09
Compare
Signed-off-by: Kristoffer Dalby <[email protected]>
Signed-off-by: Kristoffer Dalby <[email protected]>
d767a09
to
b63ec7d
Compare
Its December, all integration tests requiring networking seem to have broken...
Docker releases a patch release which changed the required permissions to be able to do tun devices in containers, this caused all containers to fail in tests causing us to fail all tests. This fixes it, and adds some tools for debugging in the future.