Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contributing document #1907

Merged
merged 5 commits into from
Apr 29, 2024
Merged

Add contributing document #1907

merged 5 commits into from
Apr 29, 2024

Conversation

juanfont
Copy link
Owner

This PR adds a CONTRIBUTING.md document, detailing headscale's contribution policy.

The document is open for discussion with the community, and we welcome suggestions and adjustments.

Our objective is to have a sustainable project that serves the community, and does not burn out its maintainer.

Copy link
Collaborator

@ohdearaugustin ohdearaugustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this really clarifies many things. I just would rewords some parts of it. Especially the part that contributors must help maintain the features, because this part is a bit unrealistic.

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
juanfont and others added 3 commits April 23, 2024 10:50
Co-authored-by: ohdearaugustin <[email protected]>
Co-authored-by: ohdearaugustin <[email protected]>
@juanfont
Copy link
Owner Author

@ohdearaugustin great suggestions :)

I will leave the PR open for a few days more, just in case someone would like to add something else.

@juanfont juanfont requested a review from ohdearaugustin April 25, 2024 16:39
Copy link
Collaborator

@ohdearaugustin ohdearaugustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just fixed some typos and added a new paragraph for the maintainability of features.

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@ohdearaugustin
Copy link
Collaborator

@juanfont still wanna leave it for some days or should I merge it?

@juanfont juanfont merged commit ff427cc into main Apr 29, 2024
104 checks passed
@juanfont
Copy link
Owner Author

Merged :)

@juanfont juanfont deleted the contributing-guide branch April 29, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants