Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add config test scale #28

Conversation

akiradeveloper
Copy link
Contributor

In #25, we discussed adding new option :test_scale. This is the implementation.

  • Add :test_scale to config (default = :normal)
  • Add -test-scale to command line option

The tests for Writeboost now uses this hint to switch to debug mode (use small test case).

To test the testcases using a small test set is a good idea.
New config item called test_scale can tell the test scale to dmtest.

new item (in config file)
:test_scale

default:
:normal

new command option:
--test-scale

Signed-off-by: Akira Hayakawa <[email protected]>
@jthornber
Copy link
Owner

Hi Akira,

I've not forgotten about it. Just catching up with things having been on
vacation.

On 30 May 2014 14:32, Akira Hayakawa [email protected] wrote:

In #25 #25,
we discussed adding new option :test_scale. This is the implementation.

  • Add :test_scale to config (default = :normal)
  • Add -test-scale to command line option

The tests for Writeboost now uses this hint to switch to debug mode (use

small test case).

You can merge this Pull Request by running

git pull https://github.com/akiradeveloper/device-mapper-test-suite feature/add-config-test-scale

Or view, comment on, or merge it at:

#28
Commit Summary

  • Add config item: test_scale
  • [writeboost] Remove DEBUGMODE and use $test_scale instead

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#28.

@akiradeveloper
Copy link
Contributor Author

Hi Joe,

This patch works fine in my environment.
Please review the code and pull it if this is what you want.
I will fix if you request.

@akiradeveloper
Copy link
Contributor Author

I will rebase to the current master and resubmit.

@akiradeveloper
Copy link
Contributor Author

please merge v2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants