wrap id in shopify gid url for ease of use

this just makes it easier to call from the frontend with the .sku property
jsterner30 · Dec 9, 2024 · 0a93e58 · 0a93e58
1 parent 23fe5ad
commit 0a93e58
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/server/src/shopify/inventory.ts b/server/src/shopify/inventory.ts
@@ -111,7 +111,7 @@ export async function getProductInventoryLocation (
   productId: string
 ): Promise<InventoryLocation[] | null> {
   const { data, errors } = await client.request(getProductLocationsQuery, {
-    id: productId
+    id: `gid://shopify/Product/${productId}`
   }) as { data: Record<string, any>, errors: unknown }
 
   if (errors != null) {

diff --git a/shared/src/model/inventory.model.ts b/shared/src/model/inventory.model.ts
@@ -19,6 +19,7 @@ export const VariantInventoryItemSchema = Type.Object({
 export type VariantInventoryItem = Static<typeof VariantInventoryItemSchema>
 
 export const UpdateInventoryRequestSchema = Type.Object({
+  // This productId is in the form of a raw number(as a string) like 7507889357006, not wrapped in a shopify gid url
   productId: Type.Optional(Type.String()),
   variantId: Type.Optional(Type.String()),
   locationId: Type.Optional(Type.String()),