feat: implement rainfall and vegetation maps #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for wfp-hungermap ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
marinovl7
approved these changes
Nov 18, 2024
There was a problem hiding this comment.
LGTM for me! @Lukas0912 will do the final approval and merge!
Lukas0912
requested changes
Nov 18, 2024
There was a problem hiding this comment.
Very nice improvement of the layer system from before, I would just suggest to add another layer on top with the deactivated non interactive countries and change the base layer to a uniformly colored base layer. Right now the differentiation of selectable and non selectable countries is not possible anymore since the overlay isn't transparent.
|
Thanks, good point! I did it as you proposed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the CORS of the WFP APIs, the map doesn't work in the demo. During development I used a Plug-In that temporarily disabled the CORS guidelines.
