Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/f 38 Implement About page #26

Merged
merged 11 commits into from
Nov 11, 2024

Conversation

jschoedl
Copy link
Collaborator

@jschoedl jschoedl commented Nov 11, 2024

  • I used the @layer base directive of tailwind for styling common elements such as h1 and p. In this case, this seemed cleaner to me than copy-pasting the same classes everywhere.
  • I put the page to /about, but did not do anything about the routing (i.e. the sidebar does not work yet).
  • The sidebar and the filters do not make sense here which will be fixed in Feature/f 29 Improve sidebar  #25
    Bildschirmfoto vom 2024-11-11 14-56-32
    Bildschirmfoto vom 2024-11-11 14-56-56

@jschoedl jschoedl self-assigned this Nov 11, 2024
@jschoedl jschoedl requested a review from marinovl7 November 11, 2024 14:05
Copy link

netlify bot commented Nov 11, 2024

Deploy Preview for wfp-hungermap ready!

Name Link
🔨 Latest commit ddeabd8
🔍 Latest deploy log https://app.netlify.com/sites/wfp-hungermap/deploys/673251adb280d70008001989
😎 Deploy Preview https://deploy-preview-26--wfp-hungermap.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@marinovl7 marinovl7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great Code Structure, great implementation, great styling! Just had to fix one thing because the styles were applied to basically everything. Next thing make sure introducing global styles doesn't affect other styles as well

@marinovl7 marinovl7 merged commit 02bd23d into main Nov 11, 2024
5 checks passed
@marinovl7 marinovl7 deleted the feature/f-38-implement-glossary-and-methodology-pages branch November 11, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants