-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/f 38 Implement About page #26
Feature/f 38 Implement About page #26
Conversation
…nd-methodology-pages
…ogy-pages # Conflicts: # src/styles/globals.css # yarn.lock
✅ Deploy Preview for wfp-hungermap ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Great Code Structure, great implementation, great styling! Just had to fix one thing because the styles were applied to basically everything. Next thing make sure introducing global styles doesn't affect other styles as well
@layer base
directive of tailwind for styling common elements such as h1 and p. In this case, this seemed cleaner to me than copy-pasting the same classes everywhere./about
, but did not do anything about the routing (i.e. the sidebar does not work yet).