build(deps): bump pdfjs-dist from 3.11.174 to 4.2.67 #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [pdfjs-dist](https://github.com/mozilla/pdf.js) from 3.11.174 to 4.2.67. - [Release notes](https://github.com/mozilla/pdf.js/releases) - [Commits](mozilla/pdf.js@v3.11.174...v4.2.67) --- updated-dependencies: - dependency-name: pdfjs-dist dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
added
the
dependencies
✅ Deploy Preview for wfp-hungermap ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@ahmtslmngcl can you check if we can use pdf-js v4? v3 had a big security vulnerability. |
CC: @bohdangarchu |
|
@Tschonti I think we don't need this dependency anyway. pdfjs is always imported from react-pdf in our code |
|
@Tschonti works fine but we also don't need it as @bohdangarchu noticed correctly |
|
But react-pdf depends on this package, so even if pdfjs-dist is not in our package.json, it'll be in our project (in yarn.lock), so make sure we're using v4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps pdfjs-dist from 3.11.174 to 4.2.67.
Release notes
Sourced from pdfjs-dist's releases.
... (truncated)
Commits
49b3881Merge pull request #18001 from Snuffleupagus/api-pageRefCache150964dRemove unnecessary check fromPDFLinkService.goToDestination(PR 17984 foll...f6cd039[api-minor] Move the page reference/number caching into the APIfa69d9aInline the helper method inPDFLinkService.goToDestination3052e99Merge pull request #18013 from Snuffleupagus/SimpleLinkService-extends-PDFLin...2b2ade7Merge pull request #18018 from Snuffleupagus/CompiledFont-tweak-caching627fe2dMerge pull request #18017 from Snuffleupagus/validate-widths85ff8f3Reduce code-duplication when caching data inCompiledFont.getPathJsd411a07Add more validation of width-data234067eMerge pull request #18014 from Snuffleupagus/validate-font-propertiesDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.