feat: add switching logic when map type get changed #127
Conversation
✅ Deploy Preview for wfp-hungermap ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Generally good direction for sure. The switch seems kinda slow, but I don't see any unnecessary network calls or anything, so I guess we can't do anything about it.
I found one major bug tho: If you click on a country that doesn't have ipc data, then switch to ipc you get put on the global map. If you now click on a country, the regions get loaded but you're not zoomed to the country. And this happens with the other maps too.
|
it's fixed now, the pr was in draft/progress, because i was having issue with double click and bohdan said like i can draft pr so that he can have look on that. But now all issues are fixed @Tschonti |
|
@Tschonti maybe we could add "Global View" button when the map type is vegetation or rainfall ? |
its already there afaik |
@bohdangarchu it's not in vegetation and in rainfall |
|
it's the current version |
yes bc you are in global view. but when you switch to veg or rainfall in country view then the button is there |
if the country data is available, the map would stay in the same position, if not then it will back in global view. I'm checking in the mapOperations.tsx, if the data of the country for specific type of map is available or not. All the 3 maps has slightly different approach to check data.