Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various Improvements from GTNH Fork #34

Merged
merged 8 commits into from
Oct 22, 2024

Conversation

glowredman
Copy link
Contributor

This PR intends to make the GTNH fork redundant, allowing the GTNH pack to use this fork and development efforts to be concentrated here.

See commit history for other changes (not necessarily based on the GTNH fork).

@jss2a98aj
Copy link
Owner

jss2a98aj commented Aug 8, 2024

The squid ink cloud backport would fit better in Et Futurum Requiem, which is currently being considered for inclusion in GTNH. The rest of the changes are definately fine though.

Edit:
EFR
Discussion about adding mods to GTNH

@mitchej123
Copy link
Contributor

+1 to moving this to EFR and pulling EFR into GTNH

Thanks for helping sync the forks up!

@Dream-Master
Copy link

if this is ported we can use upstream of Bug torch ?

@glowredman
Copy link
Contributor Author

The squid ink cloud backport would fit better in Et Futurum Requiem

I see what I can do.

if this is ported we can use upstream of Bug torch ?

Yes, that's the main intention.

@glowredman glowredman changed the title Port Squid Improvements from GTNH Fork Various Improvements from GTNH Fork Aug 21, 2024
@glowredman
Copy link
Contributor Author

@jss2a98aj Done :)

Copy link
Owner

@jss2a98aj jss2a98aj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for taking so long to get to this. Most of the changes look good.

@jss2a98aj jss2a98aj merged commit 96d94a6 into jss2a98aj:master Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants