Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat[isObjectOf]: discover symbol properties in predObj #98

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

Milly
Copy link
Collaborator

@Milly Milly commented Aug 8, 2024

Ref #94, #95

@Milly Milly requested a review from lambdalisue August 8, 2024 13:00
Copy link

codecov bot commented Aug 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.99%. Comparing base (f1c49f5) to head (3e76fa8).
Report is 1 commits behind head on symbol-properties-wip.

Additional details and impacted files
@@                  Coverage Diff                   @@
##           symbol-properties-wip      #98   +/-   ##
======================================================
  Coverage                  97.98%   97.99%           
======================================================
  Files                         50       50           
  Lines                        794      797    +3     
  Branches                      85       85           
======================================================
+ Hits                         778      781    +3     
  Misses                        16       16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Milly Milly marked this pull request as draft August 8, 2024 13:44
@Milly Milly removed the request for review from lambdalisue August 8, 2024 16:28
@Milly Milly force-pushed the symbol-properties/object-of branch from 3e76fa8 to 2e6d880 Compare August 8, 2024 16:55
@Milly Milly requested a review from lambdalisue August 8, 2024 16:56
@Milly Milly marked this pull request as ready for review August 8, 2024 16:56
@Milly
Copy link
Collaborator Author

Milly commented Aug 8, 2024

Rebased and fixes snapshots, because inspect is updated.

@lambdalisue lambdalisue merged commit 56b24ed into symbol-properties-wip Aug 8, 2024
4 checks passed
@lambdalisue lambdalisue deleted the symbol-properties/object-of branch August 8, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants