Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: refine documents and benchmarks #129

Merged
merged 4 commits into from
Aug 21, 2024
Merged

refactor: refine documents and benchmarks #129

merged 4 commits into from
Aug 21, 2024

Conversation

lambdalisue
Copy link
Member

SSIA

@lambdalisue lambdalisue marked this pull request as draft August 21, 2024 14:42
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.88%. Comparing base (243dfc5) to head (9e0b450).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #129   +/-   ##
=======================================
  Coverage   99.88%   99.88%           
=======================================
  Files          50       50           
  Lines         909      909           
  Branches      104      104           
=======================================
  Hits          908      908           
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lambdalisue lambdalisue force-pushed the refactoring branch 4 times, most recently from c39314c to 97d0dc8 Compare August 21, 2024 17:55
@lambdalisue lambdalisue force-pushed the refactoring branch 5 times, most recently from 6d5ead4 to 1b92998 Compare August 21, 2024 18:35
@lambdalisue lambdalisue marked this pull request as ready for review August 21, 2024 18:36
@lambdalisue lambdalisue merged commit 3a955b9 into main Aug 21, 2024
3 checks passed
@lambdalisue lambdalisue deleted the refactoring branch August 21, 2024 18:41
@Milly
Copy link
Collaborator

Milly commented Aug 21, 2024

@lambdalisue I think it would be better to add baseline: true option to the current side of bench.

@lambdalisue
Copy link
Member Author

lambdalisue commented Aug 21, 2024

I thought so but the number of files are too much so I gaved up. If I add baseline: true, I cannot simply perform Copy & Paste from existing code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants