-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v8 update #144
base: main
Are you sure you want to change the base?
v8 update #144
Conversation
🦋 Changeset detectedLatest commit: f02d18e The changes in this PR will be included in the next version bump. This PR includes changesets to release 25 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only reviewed a couple files as a demonstration of code review
packages/plugin-audio-multi-response/docs/jspsych-audio-multi-response.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've only gotten through 1/3rd of the files so far. Here's my review in progress so far!
@@ -1,9 +1,9 @@ | |||
<!DOCTYPE html> | |||
<html> | |||
<head> | |||
<script src="https://unpkg.com/jspsych@7.3.2"></script> | |||
<script src="https://unpkg.com/jspsych@8.0.2"></script> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the desired version? 8.0.2?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it was the most recent version at the time of writing; though we could get around this by simply doing <script src="https://unpkg.com/jspsych@8"></script>
to always query the latest version?
<script src="../dist/index.browser.js"></script> | ||
<link rel="stylesheet" href="https://unpkg.com/jspsych@7.3.2/css/jspsych.css" /> | ||
<link rel="stylesheet" href="https://unpkg.com/jspsych@8.0.2/css/jspsych.css" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check version here too
this PR closes #138, focusing broadly on updating most (self paced reading is being completely reworked) plugins to jspsych v8, which necessitates breaking changes for all plugins as certain features handled by the core package like clearing timers/displays are left to the core package itself, along with certain plugins such as the audio plugins and plugins with
button_html
-esque fields being updated.in order to improve developer experience, some plugins have added documentation where it was missing beforehand.
while all plugins function in v8, to move this PR off of draft and into merge consideration, there are several final passes and one blocking issue to content with:
ParameterType.COMPLEX
data types, specifically listing and documenting nested variablespackage.json
versioning to plugin info versioning