-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugin corsi blocks issue 141 #142
base: main
Are you sure you want to change the base?
Conversation
…bility to register the wrong sequence without ending the trial
🦋 Changeset detectedLatest commit: a0d39da The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A changeset for version bump for plugin-corsi-blocks
…nd response in plugin-corsi-blocks
} else { | ||
display_element | ||
.querySelector(`.jspsych-corsi-block[data-id="${id}"]`) | ||
.animate(incorrect_animation, animation_timing); | ||
trial_data.correct = false; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @Pavel6625 for working on this? I was about to work on this feature as well. This helps our use case as well. I am wondering if this needs to be an optional feature (turned on or off via a feature flag). The old behavior might still be useful under certain circumstances.
trial_data.correct = false; | ||
} | ||
// Only end the trial when the response length matches the sequence length | ||
if (trial_data.response.length == trial.sequence.length) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT: trial_data.response.length === trial.sequence.length
In the updated version of
register_click()
, the trial only ends when the response length matches the sequence length, regardless of whether the clicks were correct or not. This allows the user to register an incorrect sequence without ending the trial immediately.