Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some meta schema tests #244

Closed
Julian opened this issue Jan 4, 2019 · 3 comments · May be fixed by #354
Closed

Add some meta schema tests #244

Julian opened this issue Jan 4, 2019 · 3 comments · May be fixed by #354
Labels
missing test A request to add a test to the suite that is currently not covered elsewhere.

Comments

@Julian
Copy link
Member

Julian commented Jan 4, 2019 •
edited
Loading

We should have some tests whose schema is a meta schema and whose instances are schemas.

This would constitute essentially a test suite for the meta schemas, but is also likely useful for downstream implementors (like well, me!).

(This is a note to basically move these two tests here, along with some more, after deciding how to represent these in the suite).
@Julian
Copy link
Member Author

Julian commented Jan 6, 2019

https://github.com/Julian/jsonschema/pull/383/files was a PR from a user way back when who PM'ed me offering to add these, but who I didn't finish explaining how to send upstream here, so possibly we can cherry pick those commits onto this repo as a start.

@Julian Julian mentioned this issue Feb 24, 2019
Closed
@Julian
Copy link
Member Author

Julian commented Feb 26, 2019

Random likely-doable idea: the meta schema is a finite document, so we can likely at very least compute coverage over it (and make sure each property is covered).

@Julian Julian added the missing test A request to add a test to the suite that is currently not covered elsewhere. label Sep 27, 2019
@Julian Julian mentioned this issue Nov 20, 2019
Closed
2 tasks
@Julian Julian added the needs decision An issue that requires a design decision before it can be completed label Nov 29, 2019
This was referenced Nov 29, 2019
Closed
Open
@Julian Julian mentioned this issue Dec 21, 2019
Closed
@Julian Julian removed the needs decision An issue that requires a design decision before it can be completed label Apr 1, 2020
This was referenced Apr 29, 2020
Draft
Closed
@Julian Julian mentioned this issue Dec 12, 2022
Closed
@Julian Julian mentioned this issue Feb 5, 2024
Closed
@Julian
Copy link
Member Author

Julian commented Apr 6, 2024

Considering we backed some of these out (in #718 via #716 (comment)) it actually probably makes sense to close these I think.

Thanks for giving it a shot though.

@Julian Julian closed this as completed Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
missing test A request to add a test to the suite that is currently not covered elsewhere.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[244] Add a bunch of meta-schema tests ssilverman/JSON-Schema-Test-Suite
1 participant
@Julian