Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test for invalid "$anchor" syntax #301

Closed
2 tasks
handrews opened this issue Nov 11, 2019 · 3 comments · Fixed by #567
Closed
2 tasks

Test for invalid "$anchor" syntax #301

handrews opened this issue Nov 11, 2019 · 3 comments · Fixed by #567
Labels
missing test A request to add a test to the suite that is currently not covered elsewhere.
Milestone
2019-09

Comments

@handrews
Copy link
Contributor

  • No # allowed (e.g. "$anchor": "foo" is valid, `"$anchor": "#foo" is not)
  • No JSON Pointer syntax (e.g. `"$anchor": "/a/b" is invalid)

There are many other possible invalid forms, but these are the two that people are most likely to think might work.
@handrews handrews added this to the 2019-09 milestone Nov 11, 2019
@Julian
Copy link
Member

Julian commented Nov 20, 2019

This one depends on #244 -- which we should totally do but ugh yeah has not been something I've managed to hit so far... :(

@Julian Julian added the missing test A request to add a test to the suite that is currently not covered elsewhere. label Nov 29, 2019
@ssilverman
Copy link
Member

ssilverman commented Apr 25, 2020 •
edited
Loading

How does this depend on #244? I'm not doubting, just not sure how.

@ssilverman ssilverman mentioned this issue Apr 25, 2020
Closed
@ssilverman ssilverman mentioned this issue May 7, 2020
Draft
@Julian
Copy link
Member

Julian commented Jul 1, 2022

The above is wrong (my comment), we indeed can do this.

Julian added a commit that referenced this issue Jul 1, 2022
@Julian
Add tests for invalid anchors.
666d6b0 
Closes: #301
Refs: https://json-schema.org/draft/2020-12/json-schema-core.html#name-defining-location-independe
@Julian Julian mentioned this issue Jul 1, 2022
Merged
Julian added a commit that referenced this issue Jul 2, 2022
@Julian
Add tests for invalid anchors.
b62f97c 
Closes: #301
Refs: https://json-schema.org/draft/2020-12/json-schema-core.html#name-defining-location-independe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
missing test A request to add a test to the suite that is currently not covered elsewhere.
Projects
None yet
Milestone
2019-09
3 participants
@Julian @handrews @ssilverman