Double escaping single quotes #20
Conversation
|
Hi @brianpkelley thanks for the PR, I need you to do a few things for me if you can. For starters I need you to re-apply the jscs formatting from the .jscsrc file, we use 2 spaces instead of tabs and I think your editor has auto converted it making it difficult to see what you have actually changed, so I can't review it easily. We also don't need the compiled files, we do them at release time only, so if you can remove the two compiled files that'd be great! For future reference the smaller the PR the easier to approve, so single file or two at a time is much easier for me, anyway I REALLY hope you can spare some time to make the changes I would love the help! |
|
Definitely, I didn't even notice the changes, I'll fix it asap. |
…for changes and trigger the md-selected-item methods, convert back to 2 spaces from tabs
|
Sorry for the delay, we've been sidetracked and now even more pressed on time and I cannot find the time to manually re-create the changes on a clean pull of the project. And I now see that the more changes I push to our clone just updates this pull request. So also included in this is a new directive sf-changed-auto-complete based entirely off of sf-chaged which adds the methods to scope instead of a change listener. As well as some changes to the card template that suits our project, but may not be applicable to this project. I've re-converted to 2 spaces instead of tabs, and untracked the two dist files. Sorry for an inconvenience and I understand if you close the request. I'll gladly try to add my changes at a later time on a clean checkout. |
…-schema-form-material into develop # Conflicts: # src/default.html
…technique and does it better!
|
Hi @brianpkelley I'm happy to try and add the changes manually myself, was it primarily the change in src/autocomplete.html originally? |
…terial into pr/1 * 'develop' of github.com:betterMDS/angular-schema-form-material: Formatting and layout fixes removing mdInputBuilder as material-class.js now implements the same technique and does it better! Untrack dist files spacing md-auto-complete work, created new sf-changed-auto-complete to watch for changes and trigger the md-selected-item methods, convert back to 2 spaces from tabs Material upgrades Double escaping single quotes # Conflicts: # src/material-decorator.js
Upstream Changes
…update it when i work on it.
Single escaped quotes were creating a prematurely terminated string as mentioned in #6