Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal to fix issue #33 #34

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

patriziotufarolo
Copy link

@patriziotufarolo patriziotufarolo commented Nov 21, 2016

Description

Fix for issue #33

Fixes Related issues

#33

Checklist

  • I have read and understand the CONTRIBUTIONS.md file
  • I have searched for and linked related issues
  • I have created test cases to ensure quick resolution of the PR is easier
  • I am NOT targeting main branch
  • I did NOT include the dist folder in my PR

@json-schema-form/angular-schema-form-bootstrap-lead

@Anthropic
Copy link
Member

Apologies @patriziotufarolo I had the wrong @ notification in the PR template so I missed this!

Thanks for taking the time to make the PR! I have now created that member group so I wont miss them in future.

Would you be in a position to update and merge the latest changes into your change, should be a clean merge? Github won't clean merge it for some reason despite none of the latest updates touching that line.

@patriziotufarolo
Copy link
Author

patriziotufarolo commented Mar 26, 2017

Hi Anthropic,
thank you for your answer. I'm looking at the repository and I see that the directory structure changed a bit (bootstrap sub directory in src for example), that may be the reason for which github doesn't let you clean merge it.
In the next days I'll give a try to fix this again and make new PR

@Anthropic
Copy link
Member

@patriziotufarolo I made a slight change to keep both classes, if you can add that it would be great, I can do it, but I wanted to ensure you got the credit for noticing the problem :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants