Small refactor

[maurei]

• Renamed some variables and types to be consistent with JSON:API spec, where the vocabulary is 'RelationshipsObject' with its members being a 'Relationship'. Improved consistency of resource object type names and their schema ids.
• Fixed failing test from Update openapi branch #1105.

TODO:

• Rebase on openapi.

QUALITY CHECKLIST

• Changes implemented in code
• Complies with our contributing guidelines
• Adapted tests
• (N\A) Documentation updated
• (N\A) Created issue to update Templates: {ISSUE_NUMBER}

[bart-degreed]

Added some questions.

Note the cibuild fails one test, which also happens in the openapi branch. This surprises me because, on my laptop, all tests succeed. The failure is due to the location of the nullable schema in swagger.json. Download the full log from AppVeyor to see the diff. Perhaps a timing issue. Can you take a look?

[codecov]

Codecov Report

Merging #1116 (85ca072) into openapi (1c4d034) will increase coverage by 0.01%.
The diff coverage is 86.96%.

❗ Current head 85ca072 differs from pull request most recent head d877f7d. Consider uploading reports for the commit d877f7d to get more accurate results

@@             Coverage Diff             @@
##           openapi    #1116      +/-   ##
===========================================
+ Coverage    88.98%   88.99%   +0.01%     
===========================================
  Files          298      308      +10     
  Lines         8117     8180      +63     
===========================================
+ Hits          7223     7280      +57     
- Misses         894      900       +6     

Impacted Files	Coverage Δ
...NetCoreExample/Controllers/OperationsController.cs	0.00% <0.00%> (ø)
...iDotNetCoreExample/Controllers/PeopleController.cs	0.00% <0.00%> (ø)
...ApiDotNetCoreExample/Controllers/TagsController.cs	0.00% <0.00%> (ø)
...tNetCoreExample/Controllers/TodoItemsController.cs	0.00% <0.00%> (ø)
...ples/JsonApiDotNetCoreExample/Data/AppDbContext.cs	0.00% <0.00%> (ø)
...otNetCoreExample/Definitions/TodoItemDefinition.cs	0.00% <ø> (ø)
...Examples/JsonApiDotNetCoreExample/Models/Person.cs	0.00% <0.00%> (ø)
...rc/Examples/JsonApiDotNetCoreExample/Models/Tag.cs	0.00% <0.00%> (ø)
...amples/JsonApiDotNetCoreExample/Models/TodoItem.cs	0.00% <0.00%> (ø)
src/Examples/JsonApiDotNetCoreExample/Startup.cs	0.00% <0.00%> (ø)
... and 284 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c948a6a...d877f7d. Read the comment docs.

[bart-degreed]

Nice work!