Merge pull request #395 from json-api-dotnet/fix/#382

fix(Identifiable): handle null id values
json-api-dotnet · Sep 4, 2018 · 468b761 · 468b761
2 parents b073a0b + 5965fb3
commit 468b761
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/src/JsonApiDotNetCore/Models/Identifiable.cs b/src/JsonApiDotNetCore/Models/Identifiable.cs
@@ -37,6 +37,9 @@ public string StringId
         /// </summary>
         protected virtual string GetStringId(object value)
         {
+            if(value == null)
+                return string.Empty;
+
             var type = typeof(T);
             var stringValue = value.ToString();
 

diff --git a/test/UnitTests/Models/IdentifiableTests.cs b/test/UnitTests/Models/IdentifiableTests.cs
@@ -21,6 +21,16 @@ public void Setting_StringId_To_Null_Sets_Id_As_Default()
             Assert.Equal(0, resource.Id);
         }
 
-        private class IntId : Identifiable { }
+        [Fact]
+        public void GetStringId_Returns_EmptyString_If_Object_Is_Null()
+        {
+            var resource = new IntId();
+            var stringId = resource.ExposedGetStringId(null);
+            Assert.Equal(string.Empty, stringId);
+        }
+
+        private class IntId : Identifiable { 
+            public string ExposedGetStringId(object value) => GetStringId(value);
+        }
     }
 }