Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds ability to bounce on mount #36

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

shercoder
Copy link

  1. Adds boolean prop called bounceOnMount which swipes the row enough to
    expose/educate user there are buttons behind the top view.
  2. Exposes two methods: bounceRight and bounceLeft to manually
    bounce the Swipeable row.

Fixes #32

1. Adds boolean prop called `bounceOnMount` which swipes the row enough to
expose/educate user there are buttons behind the top view.
2. Exposes two methods: `bounceRight` and `bounceLeft` to manually
bounce the swipeable row.
@Cederman
Copy link

Can we please merge this?

@shercoder
Copy link
Author

@Cederman I have been thinking about merging this branch into master of the clone I made and keep that as active so other devs can continue to contribute to this lib. This repo seems dead now but it is still usable.

@Cederman
Copy link

Cederman commented Oct 12, 2017

@shercoder Ah, please do. Have you been able to come in contact with @jshanson7 to verify? If a formal handover is in place it would be nice to direct users to the new "home".

Update: Or just add you as a maintainer to this repo.

@shercoder
Copy link
Author

@Cederman I haven't done that. I'll reach out to him today.

@Cederman
Copy link

Cederman commented Dec 1, 2017

@shercoder Due to inactivity on the matter, I took the freedom to publish this under a new package (as you proposed). Hope this is fine with you @shercoder: https://www.npmjs.com/package/react-native-swipeable-row. I'll gladly add you as a maintainer.

@shercoder
Copy link
Author

@Cederman I don't have any problem with it. I think that's good.

Yes, you can add me as a maintainer for it. thank you :)

@Cederman
Copy link

Cederman commented Dec 4, 2017

Done :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants