Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cjs named import #196

Merged
merged 25 commits into from
Oct 1, 2021
Merged

Cjs named import #196

merged 25 commits into from
Oct 1, 2021

Conversation

dmail
Copy link
Member

@dmail dmail commented Oct 1, 2021

This PR tries to make esm capable to use named import on cjs files.
Unfortunately the issue seems complex and the actual fix should wait until I get feedback from rollup team.

PR ready to merge with the following changes

21.1.0

Some of the interesting links related to this:

@github-actions
Copy link

github-actions bot commented Oct 1, 2021

Performance impact

Impact on 17 metrics when merging cjs_named_import into master. Before drawing conclusion, keep in mind performance variability.

@jsenv/core metrics
Metric Before merge After merge Impact
import duration 0.693 seconds 0.763 seconds +0.069 seconds / +10.02% ↗️
import memory heap used 23.7 MB 24.81 MB +1.11 MB / +4.66% ↗️
npm tarball size 522.93 KB 523.5 KB +589 B / +0.11% ↗️
npm tarball unpacked size 2.08 MB 2.08 MB +1.98 KB / +0.09% ↗️
npm tarball file count 375 375 👻
dev server metrics
Metric Before merge After merge Impact
start duration 0.022 seconds 0.022 seconds +0.0005 seconds / +2.27% ↗️
dev server memory heap used 1.1 MB 1.13 MB +25.99 KB / +2.3% ↗️
number of fs read operation 0 0 👻
number of fs write operation 24 24 👻
build metrics
Metric Before merge After merge Impact
build duration 0.952 seconds 0.966 seconds +0.014 seconds / +1.47% ↗️
build memory heap used 38.54 MB 38.71 MB +174.85 KB / +0.44% ↗️
number of fs read operation 0 0 👻
number of fs write operation 152 152 👻
test metrics
Metric Before merge After merge Impact
test plan duration 9.34 seconds 9.3 seconds -0.042 seconds / -0.45% ↘️
test plan memory heap used 180.18 MB 141.9 MB -38.28 MB / -21.25% ↘️
number of fs read operation 0 0 👻
number of fs write operation 8144 8160 +16 / +0.2% ↗️
Generated by @jsenv/performance-impact during performance_impact#1293970008 on 4bbba71

@dmail dmail marked this pull request as ready for review October 1, 2021 05:36
@codecov
Copy link

codecov bot commented Oct 1, 2021

Codecov Report

Merging #196 (4bbba71) into master (e2441e1) will increase coverage by 0.23%.
The diff coverage is 100.00%.

@dmail dmail merged commit 2f39e6c into master Oct 1, 2021
@dmail dmail deleted the cjs_named_import branch October 1, 2021 07:07
@dmail dmail mentioned this pull request Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant