Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create basan_kuberlinov.json #1975

Merged
merged 2 commits into from
May 8, 2024
Merged

Create basan_kuberlinov.json #1975

merged 2 commits into from
May 8, 2024

Conversation

KuBerlinOV
Copy link
Contributor

@KuBerlinOV KuBerlinOV commented May 6, 2024

Dear JSCraftCamp team,

I would be very thankful for the opportunity to join your barcamp! Thank you in advance.

Best,
Basan Kuberlinov

I would like to register for JS CraftCamp.

  • My pull request contains a JSON file $name_or_nickname.json
  • I read the THE IMPORTANT STUFF at https://jscraftcamp.org/registration, the JSON file follows the template, and contains the mandatory fields like realName, githubAccountName, when, iCanTakeNotesDuringSessions, whatIsMyConnectionToJavascript and whatCanIContribute.
  • If I can NOT attend, I will either send another pull request removing my JSON file or an e-mail with the subject 'UNREGISTER' to [email protected]
  • I agree that the data I enter in the registration can be used for running the event, e.g. make a name tag, count me as participant. I acknowledge that my data are public on GitHub and I agree that I will be listed on the JSCraftCamp website as a participant.
  • I agree that photos and videos might be taken and published (e.g. on social media) during the event.
  • I understand that I might NOT get a T-Shirt, because they might be in production already
  • I asked my company about sponsoring (see open items at: https://github.com/orgs/jscraftcamp/projects/5/views/1)

Are you from a sponsoring company?

  • Yes, I am from company ?????

Copy link

netlify bot commented May 6, 2024

Deploy Preview for jscraftcamp ready!

Name Link
🔨 Latest commit 4c94eb1
🔍 Latest deploy log https://app.netlify.com/sites/jscraftcamp/deploys/663b7f03542b7c00081e7e22
😎 Deploy Preview https://deploy-preview-1975--jscraftcamp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 77 (🔴 down 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@wolframkriesing
Copy link
Collaborator

hi @KuBerlinOV cool to see your interest in the JSCC.
Please make sure to read and tick off the according boxes in your PR text.
If you need any more help feel free to let us know.

@KuBerlinOV
Copy link
Contributor Author

Hi Wolfram, I have just checked the boxes. I am not sure what should I do next? :)

@Narigo
Copy link
Member

Narigo commented May 7, 2024

Hi @KuBerlinOV, great to see you joining us this year and meeting you in person! 🥳

There is an issue with the JSON still:

Invalid participant json 'participants/basan_kuberlinov.json':
	'githubAccountName': Required
	'tShirtSize': Invalid enum value. Expected 'S' | 'M' | 'L' | 'XL' | '2XL' | '3XL', received 'UNDEFINED'
	Unrecognized key(s) in object: 'tShirt'

It looks like you've used an older version of our template - instead of tShirt we only have tShirtSize and we require the githubAccountName field now.

Dear JSCraftCamp team,

I would be very thankful for the opportunity to join your barcamp!
Thank you in advance.

Best,
Basan Kuberlinov
removed comments, updated some note property
@KuBerlinOV
Copy link
Contributor Author

KuBerlinOV commented May 8, 2024

Hi @Narigo , thank you for the answer. I have made the changes in my json file, but now I stuck at the tests with the "test Expected — Waiting for status to be reported". Sorry, I did not have experience with GitHub actions before and have to figure out on the go :)

@Narigo Narigo merged commit 02e2e18 into jscraftcamp:main May 8, 2024
5 checks passed
@Narigo
Copy link
Member

Narigo commented May 8, 2024

No worries - as a first time contributor, GitHub asks for an approval to run the GitHub action which checks the registration and we have to manually click it. Looks like it went through this time, so you did great and we could merge your registration.

Welcome to the JSCC24, @KuBerlinOV!

@KuBerlinOV
Copy link
Contributor Author

Ah, I understand, I thought these were just tests. Thank you! :)
I am looking forward to meeting you at the barcamp!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants