Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve bash syntax, mostly special char handling. #8

Merged
merged 6 commits into from
Apr 21, 2024
Merged

improve bash syntax, mostly special char handling. #8

merged 6 commits into from
Apr 21, 2024

Conversation

schorsch3000
Copy link
Contributor

As discussed in #5 i've gone along all shellcheck findings and tried to improve where possible.

@jschobben jschobben self-requested a review April 16, 2024 13:10
@jschobben
Copy link
Owner

Feel free to cherry-pick this commit:
d2cd480
It adds shellcheck to the CI run (spoiler: this PR passes!)

jschobben
jschobben reviewed Apr 16, 2024
View reviewed changes
colorscad.sh Outdated Show resolved Hide resolved
jschobben
jschobben reviewed Apr 16, 2024
View reviewed changes
colorscad.sh Outdated Show resolved Hide resolved
jschobben
jschobben reviewed Apr 16, 2024
View reviewed changes
colorscad.sh Outdated Show resolved Hide resolved
jschobben
jschobben reviewed Apr 16, 2024
View reviewed changes
colorscad.sh Outdated Show resolved Hide resolved
jschobben
jschobben reviewed Apr 16, 2024
View reviewed changes
Copy link
Owner

@jschobben jschobben left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement! With some minor changes (and a CI check) it can be merged.

jschobben
jschobben reviewed Apr 20, 2024
View reviewed changes
colorscad.sh Outdated Show resolved Hide resolved
jschobben
jschobben approved these changes Apr 21, 2024
View reviewed changes
Copy link
Owner

@jschobben jschobben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement!

@jschobben jschobben merged commit 95a0c69 into jschobben:master Apr 21, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jschobben jschobben jschobben approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@schorsch3000 @jschobben @heilig